Enable auth for binder-staging #2391
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sgibson91, I only checked your draft PR after I had some progress with this one, because I had totally forgot about it. Sorry for not building on top of that and opening a separate one :/ Also, looking at it again, it looks like the only thing missing there was a misplaced |
4 tasks
|
Closing in favour of #2393 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While manually deploying the changes in #2277, I didn't realize that we shouldn't touch
2i2c-binder-stagingand that this hub doesn't get updates anymore, so I've deployed it 🤦🏼♀️ Then, I got sucked into debugging why we didn't manage to get authentication to work in the past and spent too much time on it, to not turn it into a PR, although I realize we want to decommission it? #2026Developed based on @sgibson91's awesome work in #1579 ❤️
CILogon authentication now works, but I'm not sure about the binder part, as build appears to hang. @2i2c-org/engineering try it out at https://binder-staging.2i2c.cloud/
Todos left:
cilogon_app.pyto support abinderhubkey and not justbasehubanddaskhub